oathkeeper icon indicating copy to clipboard operation
oathkeeper copied to clipboard

`Oathkeeper` does not respect `TRACING_PROVIDER=otel`

Open mdreizin opened this issue 3 years ago • 3 comments

Preflight checklist

Describe the bug

Oathkeeper does not respect TRACING_PROVIDER=otel to use OpenTelemetry.

Reproducing the bug

docker run ... -e TRACING_PROVIDER=otel ...

Relevant log output

time=2021-12-28T23:25:00Z level=fatal msg=Unable to initialize Tracer. audience=application error=map[message:unknown tracer: otel] service_name=ORY Oathkeeper service_version=v0.38.15-beta.1

Relevant configuration

No response

Version

v0.38.15-beta.1

On which operating system are you observing this issue?

Linux

In which environment are you deploying?

Kubernetes

Additional Context

It would be nice to update ory/x to the latest version to use otel tracing provider.

mdreizin avatar Dec 28 '21 23:12 mdreizin

We will need to upgrade ory/x! However, one problem is that ory/x has developed quite a lot since we included it here and we did not yet have the time to update ory oathkeeper's config system to the new ory/x config system. So upgrading will not be as easy as just bumping the go mod version :(

aeneasr avatar Jan 02 '22 12:01 aeneasr

@aeneasr thank you very much for sharing that! I hope you will be able to migrate to the latest version in the further ;)

mdreizin avatar Jan 02 '22 17:01 mdreizin

It would be great to use otel, any updates on this issue @aeneasr?

ouranders avatar Sep 02 '22 06:09 ouranders

We want to bring in oath keeper as a hard dependency in our stack but this is somewhat of a blocker.

bodymindarts avatar Oct 05 '22 13:10 bodymindarts

Same here, we use OpenTelemetry for all of our tracing, not having this in Oathkeeper but in Hydra is a blocker for us.

ldb avatar Oct 24 '22 09:10 ldb

Still true in the latest release fwiw

docker run -e TRACING_PROVIDER=otel -ti oryd/oathkeeper serve
Thank you for using ORY Oathkeeper v0.40.0!

Take security seriously and subscribe to the ORY Security Newsletter. Stay on top of new patches and security insights.                                 

>> Subscribe now: http://eepurl.com/di390P <<

The configuration contains values or keys which are invalid:
tracing.provider: otel
                  ^-- value must be one of "zipkin", "jaeger", "datadog", "elastic-apm"

FATA[2022-11-17T18:09:25Z] Failed to initialize configuration            audience=application error=map[message:I[#/tracing/provider] S[#/properties/tracing/properties/provider/enum] value must be one of "zipkin", "jaeger", "datadog", "elastic-apm"] service_name=ORY Oathkeeper service_version=v0.40.0

edude03 avatar Nov 17 '22 18:11 edude03