elements icon indicating copy to clipboard operation
elements copied to clipboard

feat: allow passing translations to ComponentWrapper

Open dmeijboom opened this issue 1 year ago • 1 comments

This PR allows users to pass custom translations to markup components using the ComponentWrapper.

Related Issue or Design Document

Fixes #166

Checklist

  • [x] I have read the contributing guidelines and signed the CLA.
  • [x] I have referenced an issue containing the design document if my change introduces a new feature.
  • [x] I have read the security policy.
  • [x] I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security vulnerability, I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [ ] I have added the necessary documentation within the code base (if appropriate).

dmeijboom avatar Nov 19 '24 09:11 dmeijboom

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.43%. Comparing base (a5fcd44) to head (b955e6f). Report is 235 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #288   +/-   ##
=======================================
  Coverage   59.43%   59.43%           
=======================================
  Files          68       68           
  Lines         927      927           
  Branches      129      129           
=======================================
  Hits          551      551           
  Misses        371      371           
  Partials        5        5           
Components Coverage Δ
@ory/elements-react 59.43% <ø> (ø)
@ory/nextjs ∅ <ø> (∅)
:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 19 '24 09:11 codecov[bot]

Thank you for your contribution! We are moving to a new version of Ory Elements, where this is no longer a problem. Thus, I'm closing PRs against the old elements, which you can now find here: https://github.com/ory/elements-legacy

aeneasr avatar May 19 '25 08:05 aeneasr