web-audio-api-rs icon indicating copy to clipboard operation
web-audio-api-rs copied to clipboard

Chore: add more clippy lints and apply suggestions

Open orottier opened this issue 3 years ago • 3 comments
trafficstars

Working towards #114

orottier avatar Apr 14 '22 18:04 orottier

Hum sorry, I guess there is a misunderstanding on my side on this point, as I constantly remove the per file clippy directives.

As I understood #114, I though we wanted to have a common config at the crate level. Could you elaborate on the methodology you want to follow and on the final set of directive we'd like to have, so I don't constantly break what you try to achieve in the long term?

b-ma avatar Apr 15 '22 07:04 b-ma

Hey, no worries. I actually don't really have a plan currently so I never complained about it either. I'll try to come up with a strategy in the linked ticket so we can discuss it there

orottier avatar Apr 15 '22 15:04 orottier

In the mean time, maybe having some comment (e.g. // clippy::do-not-remove-clippy!) on the ones that must be there

b-ma avatar Apr 21 '22 14:04 b-ma