Orson Peters

Results 198 comments of Orson Peters

I believe our intention is to rely less and less on `arrow2` for computation. Perhaps @ritchie46 can chime in?

Why the `SinkSender` trait at all? Why not just `Write`?

`Enum` support is on its way, I suppose we can then eventually support an `Enum` with integer entries.

This is not limited to tab-separated values, the same happens for CSV with commas as well.

After some discussing some more with @stinodego we've agreed that `float_range` is problematic with regards to endpoint handling and float precision, so a `linspace`-style function would be better suited. So...

@mcrumiller We did consider `grid` but didn't like its 2D implication. We're not sure if we want a 2D (or N-D) version at this time.

@Wainberg 1. `pl.linspace` would also accept int inputs, but its outputs would always be floats (or datetimes/times/durations for those relevant types). 2. Perhaps `int_range` could use the closed argument but...

I much prefer Python's definition of `mod` to Rust's, so I'm all in favor of changing it to match Python's behavior. However this also means we must update integer division...

> By contrast rust has [mod](https://github.com/rust-lang/rust/pull/49389/commits/9255bbd035ee032f1ccd47fcf93c87f7bc2e4bad) too. @deanm0000 Euclidean division/modulo in Rust is still wrong for negative divisors. > I don't think it's a question of preference. Modulo division is...