Oren Farhi

Results 97 comments of Oren Farhi

hi @marcusreese By the Angular styleguide, "Do tolerate existing const variables that are spelled in UPPER_SNAKE_CASE..." I think it's more readable to distinguish when skimming the code. Also, the ngrx-example...

should switch to the new createAction with recommendations for action types.

@objectisliper that's a valid point. feel free to open a pr with an edit.

can you point out to an example?

yes - that's a work in progress

hi @nerijusgood try using ```[immediateCheck]="true"```

@nerijusgood the original design (from [v1 docs](http://sroze.github.io/ngInfiniteScroll/documentation.html)) would invoke the scroll handler once the element has load.

@adrienverge it sounds like what you describe there is logics that should not be part of this directive (imho). if you know up front that 10 is not enough, than...

i can suggest that you'll apply a logic which adds checks if scrollbar is present- and then add items until it does: you can apply this logics a directive -...

Nice. I'll think of how to integrate this. On Sun, Dec 24, 2017, 16:57 Adrien Vergé wrote: > Nice, it should do the trick! > > What would be even...