linuxwave icon indicating copy to clipboard operation
linuxwave copied to clipboard

Zig 0.11

Open YellowApple opened this issue 2 years ago • 5 comments

Description

Fixes some compilation errors I encountered when building under Zig 0.11.0-dev.2287+1de64dba2. ~~This PR probably ain't ready to merge yet, since there are also some errors in zig-clap that require a separate PR there (and some git submodule shenanigans, probably).~~ zig-clap is already Zig-0.11-ready on master, so that's good to go.

Motivation and Context

This is required to build linuxwave with Zig versions 0.11 and greater.

How Has This Been Tested?

zig version  # outputs 0.11.0-dev.2287+1de64dba2
zig build -Doptimize=ReleaseSafe  # to make sure the build process still works in isolation
zig build test
zig build run -- -s 0,7,1 -n 60 -v 65 -o boss.wav  # and other "presets" from the README

Screenshots / Logs (if applicable)

Types of Changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [X] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation (no code change)
  • [ ] Refactor (refactoring production code)
  • [ ] Other

Checklist:

  • [X] My code follows the code style of this project.
  • [X] I have updated the documentation accordingly.
  • [X] I have added tests to cover my changes.
  • [X] All new and existing tests passed.

YellowApple avatar Apr 18 '23 00:04 YellowApple

Hello! 🐻

Thanks for your contribution. However, I'm not sure if switching to Zig master is something that will benefit the project right now. Most of the prominent Linux distros have the latest stable version of Zig (as of 0.10.1) packaged in their repositores and switching to 0.11.0-dev.2287+1de64dba2 will mean that they won't be able to distribute linuxwave. Also, it will make the manual compilation harder for users since they will need the development version of Zig and it might have some quirks in the future.

I will keep this PR open until there is a stable release for 0.11 and we can merge it when the adoption is becoming higher.

orhun avatar Apr 19 '23 11:04 orhun

Yeah, I definitely don't expect this to be merged before 0.11's actually released; more just documenting the steps I needed to take to get it to build.

YellowApple avatar Apr 19 '23 19:04 YellowApple

I see, thank you for making that clear and submitting this PR!

orhun avatar Apr 19 '23 20:04 orhun

Zig 0.11.0 is now released! 🎉

booniepepper avatar Aug 04 '23 17:08 booniepepper

Ping @YellowApple, can you look into this once again?

orhun avatar Aug 05 '23 11:08 orhun

done in #28

thanks for your efforts everyone!

orhun avatar Oct 07 '24 21:10 orhun