org-roam-ui icon indicating copy to clipboard operation
org-roam-ui copied to clipboard

fix: solve attach id not inherited from parents.

Open MephistoMMM opened this issue 3 years ago • 3 comments

Enabling inheritance for implies that attachment links will look through all parent headings until it finds the linked attachment.

MephistoMMM avatar Feb 24 '22 15:02 MephistoMMM

Looks good for me as a quick fix. (Ideally, this option should be set to the corresponding emacs option.)

One clarification though: uniorg doesn't check the presence of the attachment—the inheritance is only used to resolve id/dir

rasendubi avatar Mar 02 '22 10:03 rasendubi

(Ideally, this option should be set to the corresponding emacs option.)

You are right, I modified it 👌

MephistoMMM avatar Mar 03 '22 14:03 MephistoMMM

Fantastic! I'll add some documentation but otherwise it lgtm

tefkah avatar Mar 21 '22 15:03 tefkah