orels-Unity-Shaders icon indicating copy to clipboard operation
orels-Unity-Shaders copied to clipboard

Published 20 hours ago • verified publisher icon orels1

Makes "Hide from Main View" options match the behavior described in the docs.

Open CheesecakeCG opened this issue 1 year ago • 2 comments

This would break compatibility with materials using current version of the shader.

The "Hide from Main View" options seem to just hide the geometry completely (for cameras and mirrors too) rather than hiding only in the main view. The docs & property labels imply these work the same way as the other 4 options for just the mirror or camera views.

CheesecakeCG avatar Jun 01 '24 01:06 CheesecakeCG

Hey, thanks for the PR. That was definitely not intentional. I was under the impression that isVR() check I had only pass for main view

orels1 avatar Jun 01 '24 20:06 orels1

I didn't test in VR before I submitted this (and forgot to hit send when I wrote this reply a week ago 😅), the issue still happens in VR. :/ This does fix it in desktop though.

Was this working in Unity 2019 or 2022.3.6f1? Maybe something's broken with the VR check?

CheesecakeCG avatar Jun 15 '24 19:06 CheesecakeCG

I'll close this PR as i re-did this fix a bit differently myself. Thanks for reporting the bug tho! And sorry it took so long 😓 I'm trying to get it all ready for release and I finally got to this.

orels1 avatar May 11 '25 00:05 orels1