tom-select
tom-select copied to clipboard
orchidjs
Seeking Maintainers
Bug description
I no longer have time to maintain Tom Select
Expected behavior
We need one (or more) experienced TS developers with spare time to take over
Steps to reproduce
Start open source project, invest time, work/life take over, os project suffers...
Additional context
Who made this issue tracker anyways!
👋 I use this library and IMO it's the best option for someone not looking to drag in React/etc. While I candidly can't commit huge amounts of time (so I definitely won't be doing wholesale refactors/rewrites), I'd love to help fix up small bugs.
I'm currently facing https://github.com/orchidjs/unicode-variants/issues/2, which is a blocker for me since it's a transitive dependency of tom-select. That's a separate project, but still under the same org, so I'm hopeful that I could contribute fixes there as well.
Could you clarify what level of involvement you're looking for in a maintainer? That is, if I can submit PRs, test my own code, prove that it's working as intended, and so on, are you willing to rubber-stamp, merge, and publish to npm? Or are you looking for someone to take full repo/npm permissions? I'd prefer the former, but would be willing to do the latter if required.
Looking for the latter. There are quite a few existing pull requests and issues that need attention.
Gotcha. It looks like the existing PRs aren't horribly complex. I'd like to volunteer, though hopefully some others can chip in to share the load as well.
@oyejorge I got the org invite - thanks! How do you want to handle npm publishes?
Just sent you an invite for npm. Running the ./release.sh bash script will do most of the work
Perfect, thank you. I accepted it. How about for other packages like https://github.com/orchidjs/unicode-variants?
Right. Just sent an invite for the other packages
On Thu, Nov 14, 2024 at 9:57 AM Nathan Sarang-Walters < @.***> wrote:
Perfect, thank you. I accepted it. How about for other packages like https://github.com/orchidjs/unicode-variants?
— Reply to this email directly, view it on GitHub https://github.com/orchidjs/tom-select/issues/797#issuecomment-2476948849, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH6YRC2IJVYO67QZQE77ZT2ATJABAVCNFSM6AAAAABRXIHJC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZWHE2DQOBUHE . You are receiving this because you were mentioned.Message ID: @.***>
Many thanks! I should be good now. Assuming there's no one else to review my own changes, I'll go ahead and start doing things, sound good? Hopefully I manage to not break anything 🙂
This is awesome. I use tom-select and its one of the best libraries out there. I am not a js/ts expert but will keep an eye on issues and see if I can contribute. Thanks for taking this on @nwalters512
I agree, from my point of view it is one of the best libraries for fancy selects. Thanks @nwalters512 for taking over and thanks @oyejorge for all the effort you put into it.
@oyejorge Thank you for creating this library! I've enjoyed using it in my projects for nearly 2 years ❤️
@nwalters512 Thank you for taking this on! I am glad we can continue using Tom Select 😊
Gotcha. It looks like the existing PRs aren't horribly complex. I'd like to volunteer, though hopefully some others can chip in to share the load as well.
I can support you with this. I've been looking for a project that I can contribute to for some time now.
/EDIT ping @oyejorge @nwalters512
One easy thing to do reduce the burden for maintainers is to fully automate the release process:
- Switch to semantic commit messages https://www.conventionalcommits.org/en/v1.0.0/
- Configure semantic-release https://semantic-release.gitbook.io/semantic-release
I looked at the release.sh script and it does nothing very interesting (it does sanity checks that will be part of any automated release pipeline like running tests).
While I could set this up, it's often very annoying to do without merge permissions (since you can't really test the full pipeline without having merges). I have done this for 10+ projects and what I see from the release script leads me to believe that the defaults for semantic-release will work just fine.
I started to use this component recently a lot, but I am not sure I will have enough time to maintain it fully. Probably I could participate at PRs discussion and provide general feedback. No any promises. @oyejorge
I use tomselect in our project (hundreds of pages/js/components.. a pretty big ERP system), but had to modify source code to add other features that are missing (which I would be happy to integrate them in the project though). Based on personal commitments I may be able to help with the mainteinance. In case, feel free to contact me (see profile)
Ok, let's get serious about finding a/some new maintainer(s). If you'd like to take over, please show your interest/commitment by sharing your own forked Tom Select repo. Please include a short list of updates you made to the codebase and a link to your published package on npmjs.
Ok, let's get serious about finding a/some new maintainer(s). If you'd like to take over, please show your interest/commitment by sharing your own forked Tom Select repo. Please include a short list of updates you made to the codebase and a link to your published package on npmjs.
LOL. I have none of that. There are plenty of pull requests to go through and I'd just like to get some of those reviewed and merged.
@ericscales if you'd like to work with contributors to get their PRs into a mergeable state and tested, I can do the final review/merge/release.
As far, as I can see here are people who actively using this component and want some issues to be fixed. They created PRs. But because no maintainers are here PRs stale.
The solution to this would be:
- Implement feature/fix
- Add some tests
- Other active members review that PR. 3 from 5 reviews are required.
- Once condition met -- PR is merged.
@oyejorge Does this sounds good?
@KES777 - yes, I don't understand it. I understand not having the time to maintain a repo, and have the utmost respect for everyone that contributed to this amazing component. However, I don't understand the point of this thread if the current maintainers that need help maintaining the repo, are going to seek help and then add a bunch of restrictions and caveats months later.
There are many people here who had offered to help. Is it all going to be perfect, no; but, let us try and help in our free time.
I am glad that it is handled this way. Tom-Select is downloaded tenth of millions times every month and you cannot simply invite everyone who leaves a comment to become a contributor with merge permissions in such a widely used project. Thank you @oyejorge for handling it responsible.
@kevinpapst People did theirs PRs here and want to continue contribute/investigate their time. So @oyejorge can review them and decide is it was done good then he can grant merge permission.
Otherwise the steam will go out and such a widely used project with tenth of millions times downloads every month just die.
Example: https://github.com/orchidjs/tom-select/pull/905
Why this should not be merged? May you grant that person review permission? You still can restrict merges to code owners and go through PRs with 3-5 reviews bi-weekly for the first time. After 6mon you can grant merge permission to some people with many reviews. Let's get it forward! Do not ask people to do something abstract.
*Please note. I do not want to say something bad. You and others who contribute and maintain do the great job! I just proposing to make requirement a bit softer and/or achievable.
@ericscales if you'd like to work with contributors to get their PRs into a mergeable state and tested, I can do the final review/merge/release.
Fair enough. I commented on a number of PRs to ask what was needed to get them merged.
Hi @oyejorge , would be interested in helping maintain the project - what could potential next steps be . Would love to help out
Hey @oyejorge I'm also able to Support and maintain this project. I use tom-select in a private project and found some bugs in the past. But i'm unhappy that Open PRs are'nt checked and merged.
Should i help to review them?
Kind regards Hannes
