orbit-db-store icon indicating copy to clipboard operation
orbit-db-store copied to clipboard

Improperly comparing CIDs

Open vaultec81 opened this issue 5 years ago • 0 comments

CIDs/multihash can be encoded in many different formats. base58btc, base32, etc. Comparison via normal javascript methods do not work. Use CID.equals(CID2) instead. https://github.com/orbitdb/orbit-db-store/blob/1b628b6a9035e2b0fda2f68052797c6b0a0a74b4/src/Store.js#L302-L304

vaultec81 avatar Apr 09 '20 22:04 vaultec81