orbea

> Maybe I'm missing something Yes, it seems yara doesn't use `AC_CONFIG_HEADERS` so there is no `config.h`, but unfortunately adding it is not as trivial as I hoped due to...

I force pushed with two new commits, the first to add a description to `AC_DEFINE` as shown in the autoconf documentation which seems required with `AC_CONFIG_HEADERS` and another to add...

> Adding a config.h does not solve the points i raised about avoiding the use of the 32-bits pread function when autotools is not used. Is it possible to test...

Thanks for elaborating, I understand your concern now and yes another build system would have to replicate the defines and autoconf tests. I am not certain if setting `_FILE_OFFSET_BITS` unconditionally...

> I prefer not having to deal with a `config.h` file, and go with @vthib's proposal. Its your call, I removed the `config.h` commit and went with @vthib's proposal. I...

Thank you! And sorry for forgetting about this PR, I had other things distracting me and lost track of it...

Duplicate of issue https://github.com/michaelforney/samurai/issues/36.

@mgorny Is there a Gentoo issue for this? I tried reproducing it, but it seems to just work for me... I tried this with the current samurai commit (https://github.com/michaelforney/samurai/commit/217059f21e2d1f016f7ba044b36d12de95788cf3), samurai-1.2...

Ah, reading the discussion in PR https://github.com/libjxl/libjxl/pull/3196 was also helpful for understanding. There is an argument that projects shouldn't produce invalid `build.ninja` files and perhaps the upstream fix is all...

This was reported to Gentoo by a tinderbox since I made this PR. https://bugs.gentoo.org/927974