Oran Agra

Results 512 comments of Oran Agra

we understand that for a database mainly composed of (large) streams, it makes sense to ask to limit the memory by trimming the streams rather than eviction a complete key....

I usually object this kind of optimization changes unless we prove they actually make a difference. these are typical things that an optimizing compiler doesn't need you to tell it....

i agree with both statements. but i'm arguing that in some cases the compiler would have already done these on it's own (grouping similar conditions and moving computation around), and...

This was discussed in the past, IIRC called WAITAOF. Should certainly be on our roadmap. To make it even more useful, we wanted the REPLCONF ACK sent by the replica...

@MeirShpilraien didn't we agree to fix spop in a breaking manner? or did we say that we'll first fix it in a non-breaking manner, and then break it in a...

Ohh, I forgot. Better outline that plan in the top comment. @yossigo do you think we can put this in 7.0?

@yossigo please take another look. we attempted to include only the bugfix in this PR without fixing other things that can be considered a breaking change. along the way a...

@redis/core-team not really a major-decision since there's no interface change, but it's a sensitive area so maybe one of you wants to review it too. besides merging it to unstable,...

the PR **doesn't** include a breaking change (just a bug fix). unless someone wrote code that actually relies on the bug (but that can be true for any bug fix)....

@yossigo just to be clear, you mean that for client connections we can support multiple plugins, even working side by side, but these won't (at least in this stage) integrate...