Oran Agra

@ashtul thanks. I feel that such a block of non-straight-forward code, should have one or two short comments that explain it. Also I suppose the constant of 32 needs to...

p.s. the tests fail: ``` "test "ZADD XX updates existing elements score - $encoding" { [exception]: Executing test client: Bad protocol, '' as reply type byte. Bad protocol, '' as...

I improved the comments a bit, few remaining things: 1. what's `rds` in `rds_utoa`? 2. maybe we should consider simply placing that function (a two line for loop) into the...

@ashtul are you gonna carry this through?

So the master in this case will replicate a single `CLUSTER SLOTFLUSH` command (rather than a ton of DEL commands) to the replica, but what about an AOF file? i...

@weim0000 i think we're still missing notifyKeyspaceEvent. Regarding CLUSTER being an admin command, i don't see a problem with that. i do think it's better to send one command down...

> @oranagra There is a scenario where the master node of the cluster has a replica in standalone mode,and it is strange to execute the `cluster slotflush` command on this...

@weim0000 thank you. this is ready for merge IMO, can you please update the top comment with the scenario in which it happens, and the implications of the bug /...

few random notes: 1. I think we want to avoid per-key configs (i.e. XSIZE), which is why XADD has the trim feature. 2. we do have some type specific configs...

A MAXSIZE feature to XADD and XTRIM sounds reasonable to me (it's basically an additional trimming threshold). A global config that controls the maximum size of each stream is just...