Oran Agra

i'm not certain "multiple administrators" is right. note that some configs like `maxmemory`, `save`, and `oom-score-adj` are probably related to administrator and hosting, but others are more about the application,...

these are just a few examples, there are more. * `notify-keyspace-events` - ideally you're right, client wanting to listen for these should not depend on a global config, but in...

@guybe7 the RDB version was incremented, so you can now update this PR

i don't think it's SIGTERM sent by a user, it's a fortification assertion. involving LINDEX on a listpack. if you happen to learn how to reproduce it, please send the...

haven't reviewed the changes yet. i'm not clear about the propagation tests question, what is the alternative? i don't think each and every command needs a propagation test, we mainly...

i'm sorry.. looks like i'm inconsistent with myself (2 months apart). skimmed though the code again, i can't recall why i thought that this PR requires propagation tests (i don't...

@soloestoy can you please respond to my above comment (https://github.com/redis/redis/pull/12957#pullrequestreview-1838800154) and update the description at the top.

so `repl_total_reconnect_time` is what i suggested (similar to `total_eviction_exceeded_time`), right? (cumulative time of being disconnected (when configured as a replica). is `repl_current_reconnect_time` similar to `current_eviction_exceeded_time`? is it synonym to `master_link_down_since_seconds`...

i don't like metrics that focus on the last event (e.g. failure state) and how long it lasted (i also don't like rdb_last_bgsave_time_sec, rdb_last_cow_size), it means that if another event...

i think they are different since master_attempt_connect_time counts time in the previous state, and imagine a case where half a second after success, the connection is lost again, that metric...