Oran Agra

Results 512 comments of Oran Agra

@yossigo it makes sense to split it into several stages, and review each separately, but then i may be worried that we're not seeing the end goal properly when working...

@pizhenwei i'm really sorry for not responding sooner (wanted to wait till i have a chance to look at the code) we're still in the vortex of redis 7.0 (trying...

@pizhenwei thank you for the adjustments and the detailed list of changes. in the future, if you have to rebase, please force-push it in a separate push, so that we...

@pizhenwei not sure about that GH issue, but let's put it aside and try to move on. i wrote that comment before i saw your other branch and wrote the...

i think that considering that we don't expect to have more than 4 extensions, maybe we can start with an array rather than a list (faster index), and that in...

yeah, i realize you used the startup argument for now. i think it'll be nice to expose better integration with configs so they can be changed / queried at runtime,...

thanks take your time.... p.s. i took at look at the branch you linked, what you did will only allow interacting with the CONFIG command, not with the config file...

closed in favor of #10882

ohh, sorry, i got carried away, confusing it with the other dup, but actually it's a different topic. re-opening.

for the record, we do already have plans to improve IO threads (hopefully in the near future) to better offload writes (and TLS) towards client, and we are also already...