terraform-provider-oci
terraform-provider-oci copied to clipboard
Corrects missing `is_shareable` attribute in results from data source `oci_core_volume_attachments` #2191
Data source oci_core_volume_attachments is missing is_shareable attribute so that it returns false for all results. This change adds the missing attribute and updates related documentation to indicate inclusion of the attribute.
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:
- PR author: jeliker1
- [email protected] (@jeliker1)
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.
When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.
If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.
Thank you for your valuable contribution. We greatly appreciate your efforts in submitting this pull request. However, I regret to inform you that we are unable to merge it directly on GitHub at this time.
Our internal policy requires that all pull requests undergo thorough local testing and review before they can be merged into the main codebase. This process ensures the quality and stability of Terraform-Provider-OCI.
We understand that this may cause some inconvenience, but please rest assured that your contribution is highly valued. Our team will carefully review and test your changes locally to ensure they meet our standards.
We appreciate your understanding and patience in this matter. If you have any questions or need further assistance, please don't hesitate to reach out. Thank you once again for your contribution.
Thank you for signing the OCA.
@tf-oci-pub hoping someone has opportunity for review. I think the change is quite simple and logical making me think the review ought to be a low-effort task.
Looks like this got fixed through other means and pull request is no longer necessary. Can you confirm?