terraform-provider-oci icon indicating copy to clipboard operation
terraform-provider-oci copied to clipboard

Fix identity domain destruction by deactivating the identity domain before deletion

Open F21 opened this issue 2 years ago • 4 comments

The current implementation for deleting an identity domain attempts to call delete on it immediately. This will fail because an identity domain must be deactivated before it can be deleted. See API reference: https://docs.oracle.com/en-us/iaas/api/#/en/identity/20160918/Domain/DeleteDomain

This PR fixes the issue by deactivating the identity domain and waiting until it is marked as deactivated before attempting to delete it.

Closes #1781

F21 avatar Mar 01 '23 01:03 F21

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

Can someone from Oracle can take this over even the PR contributor has not signed the OCA !? This is blocking us. It could be very easy to re-submit the PR and being able to be reviewed/approved !

thpham avatar Jul 17 '23 18:07 thpham

@thpham, oracle has approved my OCA, but it seems they don't really accept external contributions for this project.

F21 avatar Jul 17 '23 22:07 F21

Thank you for your valuable contribution. We greatly appreciate your efforts in submitting this pull request. However, I regret to inform you that we are unable to merge it directly on GitHub at this time.

Our internal policy requires that all pull requests undergo thorough local testing and review before they can be merged into the main codebase. This process ensures the quality and stability of Terraform-Provider-OCI.

We understand that this may cause some inconvenience, but please rest assured that your contribution is highly valued. Our team will carefully review and test your changes locally to ensure they meet our standards.

We appreciate your understanding and patience in this matter. If you have any questions or need further assistance, please don't hesitate to reach out. Thank you once again for your contribution.

tf-oci-pub avatar Aug 28 '23 13:08 tf-oci-pub