navigate link should be hidden if webappCtags is false and viewing historical revision of a file (Bugzilla #18482)

[vladak]

status NEW severity normal in component webapp for --- Reported in version unspecified on platform ANY/Generic Assigned to: Lubos Kosco

On 2011-06-03 13:38:42 +0000, Vladimir Kotal wrote:

Navigate works normally when I view latest version of a file, e.g.

http://grok.cz.oracle.com:8080/source/xref/onnv-clone/usr/src/tools/scripts/wsdiff.py

but when I display older version of the file:

http://grok.cz.oracle.com:8080/source/xref/onnv-clone/usr/src/tools/scripts/wsdiff.py?r=2538%3Ab5894d78c55a

Navigate does not do anything.

On 2011-06-03 16:47:04 +0000, Knut Anders Hatlen wrote:

We currently don't have the information we need to generate the navigation panel for other revisions than the most recent one. It's the information from ctags that's missing, since we only run ctags during indexing, and we only index the latest revision.

If we could run ctags when generating xref on the fly for older revisions, we could both solve this issue and get proper links to definitions within the same file (now all links generate a new search if you look at an old version, even when the definition is in the same file).

If we don't fix it, we should at least disable the navigate link for older revisions to reduce the confusion.

[vladak]

I'd vote for just disabling the Navigate link when viewing non-tip version of a file. This should be done in mast.jsp, possibly using something stored in PageConfig object to differentiate between historical revision and current tip.

[vladak]

The Navigate window is properly filled when the webapp is run with the webappCtags property set to true since in this mode on-the-fly xref generation is done. So, the link should not be displayed (or greyed out) only in case when this property is false and displaying historical revision of a file.