opengrok icon indicating copy to clipboard operation
opengrok copied to clipboard

lack of ui parameter propagation in Repository and related classes

Open vladak opened this issue 3 years ago • 0 comments

The ui parameter used in getLastHistoryEntry() is largely ignored. Firstly, in the repository.getLastHistoryEntry() fallback path - none of the Repository#getHistory() methods actually have the ui parameter. Also, the historyCache.get() can fall back to repository.getHistory() as is the case with FileHistoryCache#get(). Even the classes that override Repository#getLastHistoryEntry(File file, boolean ui) ignore the ui parameter - because the getHistory() method they are usually based on lacks it.

Originally posted by @vladak in https://github.com/oracle/opengrok/pull/3861#issuecomment-1005538281

vladak avatar Jan 05 '22 10:01 vladak