oci-go-sdk icon indicating copy to clipboard operation
oci-go-sdk copied to clipboard

v65.77.1 appears to be have tagged the wrong release

Open iwahbe opened this issue 1 year ago • 2 comments

I think that https://github.com/oracle/oci-go-sdk/releases/tag/v65.77.1 was double tagged. Go serves v65.77.1 from a tag published on Oct 23, 2024 (source).

This doesn't make sense, since v65.77.1 was published on Oct 29, 2024.

The result is that a dependency that depends on features in v65.77.1 fails to compile.

You can reproduce the result yourself with this program (since containerengine.InstallAddonRequest.IsOverrideExisting was added in v65.77.1):

package main

import (
	"fmt"

	"github.com/oracle/oci-go-sdk/v65/containerengine"
)

func main() {
	request := containerengine.InstallAddonRequest{}
	var b bool
	request.IsOverrideExisting = &b
	fmt.Println("Hello, 世界")
}

I think the easiest way to fix this would be to publish v65.77.2.

iwahbe avatar Oct 31 '24 11:10 iwahbe

Hi @iwahbe, thanks for pointing this out. I'm unsure of why exactly you are running into this error with this specific release, as I do see that the 65.77.1 draft release and tag seem to point to the correct commit: https://github.com/oracle/oci-go-sdk/releases/tag/v65.77.1. Either way, the next release version is v65.78.0 - could you try this release out and see if it contains the changes you need? Thank you

JoshuaWR avatar Nov 12 '24 21:11 JoshuaWR

Hi @JoshuaWR. Thanks for getting back to me. The 65.77.1 releases point to the correct commit in GitHub, but pkg.go.dev (which go mod uses) cached the wrong commit. My best guess is that the tag was moved.

v65.78.0 at least points to the right day in pkg.go.dev, so I'll assume its the right commit.

iwahbe avatar Nov 13 '24 09:11 iwahbe