nosql-java-sdk
nosql-java-sdk copied to clipboard
Handle Edge Cases on NullValue.java - todo: "Sort empty Types" - Contributes to Issue #141
Hello,
As described in the issue related to handle edge cases on the issue #141 "sort empty types" , I would like to suggest an approach to solve this issue.
This PR updates the compareTo method in the NullValue class to clarify how "empty types" should be handled in comparisons. The TODO comment has been ameliorated by listing relevant class types (EmptyValue, ArrayValue, BinaryValue, BooleanValue, ... ) that could be null.
This attemps to clarify edge cases scenarios.
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:
- PR author: ronaldngounou
- [email protected] (@ronaldngounou)
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.
When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.
If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.