Improve Logging Accuracy in onFinalize Method

[logresearch]

This PR addresses an issue in the onFinalize method where the logging statement could potentially mislead the reader into believing that the execution was successful, even in the presence of an error. The logging sequence has been revised to ensure that the log message accurately reflects the method’s state.

Description

Previously, the onFinalize method logged “Executed successfully: “ before checking for errors. This sequence could result in misleading logs when errors are present, as the success message would still be logged.

Changes Made

• The check for errors (error != null) and the corresponding AssertionError throw now precede the success logging.
• The log message “Executed successfully: “ is printed only if no errors are detected, ensuring that the success message aligns with the method’s actual state.

Impact

This change ensures that log messages accurately represent the state of the method, providing clearer and more reliable logging output for error tracking and debugging purposes.

[oracle-contributor-agreement[bot]]

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

• PR author: logresearch
• [email protected] (@logresearch)

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

[fniephaus]

Thanks for your contribution. Could you please sign the OCA so we can start integrating this?

[logresearch]

Thanks for your contribution. Could you please sign the OCA so we can start integrating this?

Hi @fniephaus, I've already signed the OCA last week.

[fniephaus]

@logresearch thanks! are you sure you used the email address mentioned in https://github.com/oracle/graal/pull/9359#issuecomment-2247100163?

[logresearch]

@logresearch thanks! are you sure you used the email address mentioned in #9359 (comment)?

OH,NO. I will do it now.

[oracle-contributor-agreement[bot]]

Thank you for signing the OCA.

[entlicher]

Your change is in: https://github.com/oracle/graal/commit/978c81e6180874ee7676c2f13d30eccff82a1e25 Thanks for your contribution.