graal icon indicating copy to clipboard operation
graal copied to clipboard

Fix GetDirectBufferCapacity() implementation

Open koutheir opened this issue 3 years ago • 5 comments

GetDirectBufferCapacity() JNI must return -1 if the given object is not a direct java.nio.Buffer.

koutheir avatar Jul 11 '22 18:07 koutheir

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

  • PR author: @koutheir

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When singing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

I already signed the OCA months ago.

koutheir avatar Jul 11 '22 18:07 koutheir

Hi, @koutheir, Thank you for contributing to GraalVM, could you please provide answers to the following questions?

Is your PR complete and ready for review? Did you have a conversation about these changes with some team members and you would like for them to review this as they have more context? please mention them Do your changes rely on other changes made in a separate open PR? if yes please link it to this one

oubidar-Abderrahim avatar Jul 18 '22 12:07 oubidar-Abderrahim

Is your PR complete and ready for review?

Yes.

Did you have a conversation about these changes with some team members and you would like for them to review this as they have more context?

No.

Do your changes rely on other changes made in a separate open PR?

No.

koutheir avatar Jul 18 '22 12:07 koutheir

@christianwimmer could you please assign a reviewer for this PR? Also please let me know if I should mirror it into Ol-Bitbucket? Thank you.

oubidar-Abderrahim avatar Jul 18 '22 14:07 oubidar-Abderrahim

I might have done something incorrectly. I pulled changes and merged from the master branch, and applied the same changes again in order to resolve the conflicts. Can we continue in #4838 ?

koutheir avatar Aug 23 '22 19:08 koutheir

Most likely you removed all commits in a push and that led the automation to believe that your changes were already integrated.

peter-hofer avatar Aug 25 '22 11:08 peter-hofer