graal icon indicating copy to clipboard operation
graal copied to clipboard

Published 20 hours ago • verified publisher icon oracle

Add lambda methods test in debuginfotest

Open zakkak opened this issue 3 years ago • 3 comments

Catches cases like https://github.com/graalvm/mandrel/issues/355 caused by JDK-8281266

zakkak avatar Feb 10 '22 15:02 zakkak

The underlying issue has been fixed in jdk17u-dev and is expected to land in OpenJDK 17.0.4 (July 19 2022). As a result we could consider this PR for inclusion in GraalVM 22.2.0 (July 26, 2022).

zakkak avatar Mar 23 '22 10:03 zakkak

Hi, Thank you for contributing to GraalVM, when this PR is ready for review, please let me know so that I can take care of it and assign it to the proper engineer.

oubidar-Abderrahim avatar Jul 18 '22 10:07 oubidar-Abderrahim

Hi @zakkak, while already at it, it would be great to also test setting and entering breakpoints in lambdas via

  • a line breakpoint in the body of the lambda function
  • method breakpoint on the name of the lambda function

olpaw avatar Sep 20 '22 10:09 olpaw

Hi all, this is on my to-do list (just not high enough :) )

zakkak avatar Sep 29 '22 10:09 zakkak

@zakkak please fix the merge conflict before we make the internal PR.

olpaw avatar Nov 03 '22 12:11 olpaw

@zakkak please fix the merge conflict before we make the internal PR.

Done, should be good to go.

zakkak avatar Nov 04 '22 08:11 zakkak

@olpaw could you please create the internal PR for this?

zakkak avatar Nov 09 '22 09:11 zakkak

@olpaw @oubidar-Abderrahim I rebased once again to resolve some new conflicts. Please review and merge if OK.

zakkak avatar Dec 02 '22 11:12 zakkak

Ping @olpaw @oubidar-Abderrahim ^^

zakkak avatar Jan 30 '23 12:01 zakkak

Hi @zakkak , it seems there are some more conflicts to solve, please do so when possible. @olpaw Once the conflicts are solved, can we integrate this PR into main, or are there any more changes required?

oubidar-Abderrahim avatar Feb 03 '23 16:02 oubidar-Abderrahim

Hi @zakkak , it seems there are some more conflicts to solve, please do so when possible.

@oubidar-Abderrahim done. Please note that this is the 3rd rebase after the PR's approval. Since this has already been approved, and the conflicts were mostly on line number differences, could you please push it for internal review once the github actions run?

zakkak avatar Feb 08 '23 12:02 zakkak

@oubidar-Abderrahim the CI is happy and there are no conflicts, could you please push this to the internal queue?

zakkak avatar Feb 14 '23 13:02 zakkak

Our CI has unfortunately mirrored this to https://github.com/oracle/graal/pull/6895.

fniephaus avatar Jun 27 '23 13:06 fniephaus