docker-images icon indicating copy to clipboard operation
docker-images copied to clipboard

Adjust the HEALTHCHECK for prebuiltdb extension

Open felipecrs opened this issue 3 years ago • 1 comments

This turns down the startup time of the container from 1m to 30s, which in most cases is sufficient for the prebuiltdb ones to be ready.

felipecrs avatar Sep 14 '22 23:09 felipecrs

Thanks a lot for the PR, @felipecrs!

@abhisbyk, please review this PR.

gvenzl avatar Sep 14 '22 23:09 gvenzl

@felipecrs so many changes just for a minor health interval enhancement of 30s is not worth it.

Can you use the --health-interval 30s to your podman run/docker run command to get around this.

yunus-qureshi avatar Aug 01 '23 14:08 yunus-qureshi

@yunus-qureshi I can do many other things to get around this. My goal was to fix it for everyone.

The change I did on all files were to avoid hardcoding the path to the healthchecker. If you don't like it, I can simply copy the path to the healthchecker, thus making the change only on the prebuiltdb.

felipecrs avatar Aug 01 '23 14:08 felipecrs

@felipecrs a pre-built db image also doubles up as a image which can be used to create a new DB from scratch if you provide a mount for the oradata location

yunus-qureshi avatar Aug 01 '23 15:08 yunus-qureshi

That's true, but I think that defeats the purpose of the prebuiltdb extension, meaning we probably don't need support this use case, do we?

felipecrs avatar Aug 01 '23 15:08 felipecrs

Yes, we do. The XE and Free container-registry images (container-registry.oracle.com/database/free:latest) are all pre-built with DB charset of AL32UTF8. If users need a DB with an alternate charset then we need a fresh DB to be created using the same prebuilt image.

See https://github.com/oracle/docker-images/issues/2673

At this point I don't think there is pressing need for this PR unless we see more users asking for it

yunus-qureshi avatar Aug 01 '23 15:08 yunus-qureshi

Right. Thanks for the feedback.

felipecrs avatar Aug 01 '23 15:08 felipecrs

@felipecrs thanks for understanding and your contribution.

yunus-qureshi avatar Aug 01 '23 15:08 yunus-qureshi