terraform-oci-base icon indicating copy to clipboard operation
terraform-oci-base copied to clipboard

Add logging to base module

Open hyder opened this issue 4 years ago • 1 comments
trafficstars

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

We should be able to add VCN flow logs, bastion and operator logs as well as any other infra that is created on top of the base module.

New or Affected Resource(s)

Potential Terraform Configuration

# Copy-paste any Terraform configurations for how the requested feature may be used. 

References

hyder avatar Apr 16 '21 05:04 hyder

I would advice to implement log feature one level lower when composing with other modules, instead of directly in base module.

e.g: vcn module is responsible to expose inputs to enable or not its own logs, same for compute, etc.

Base module will configure this setting for each resource as needed, but could own the loggroup creation.

kral2 avatar Apr 16 '21 08:04 kral2