Allow `default` to be set on an OptimizelyVariation that has `variation` also set

[grug]

This would be a nice quality of life improvement to have as we often have experiment code that looks like this:

<OptimizelyExperiment experiment="some_test">
  <OptimizelyVariation variation="original">
    <OriginalComponent />
  </OptimizelyVariation>
  <OptimizelyVariation variation="some_variant">
    <VariantComponent />
  </OptimizelyVariation>
  <OptimizelyVariation default>
    <OriginalComponent />
  </OptimizelyVariation>
</OptimizelyExperiment>

It would be nice to be able to express the above as:

<OptimizelyExperiment experiment="some_test">
  <OptimizelyVariation default variation="original">
    <OriginalComponent />
  </OptimizelyVariation>
  <OptimizelyVariation variation="some_variant">
    <VariantComponent />
  </OptimizelyVariation>
</OptimizelyExperiment>

As it is more concise and just as readable.

Is there a chance of seeing this improvement land in the SDK?

-Dave

[Tamara-Barum]

Internal ticket created: [FSSDK-8653]

[alexparish]

I'm very keen on this change as my company has suffered production incidents due to misunderstandings around how this works. It was assumed that adding a default attribute to an <OptimizelyVariation> component that has a variation would suffice.

Following those incidents, I felt it necessary to write an ESLint plugin to ensure our engineers implement an <OptimizelyVariation> component that has a default attribute but no variation attribute.

If the internal ticket hasn't been progressed, would you welcome a pull request?

[mikechu-optimizely]

I'm working on this Issue and #225 in this sprint.

Always welcome pull requests. This helps all stakeholders (including internal) understand the requirement / POV as well as shorten up the implementation.

[mikechu-optimizely]

I have a dependent branch ready with this bug fix and test coverage.

[grug]

This is great news! Can't wait to see it.

[junaed-optimizely]

Seems like it has been released a while ago.. Closing..!