react-sdk icon indicating copy to clipboard operation
react-sdk copied to clipboard

fix user overrides: merge overrides with current user attributes

Open Sillhouette opened this issue 4 years ago • 2 comments

This pull request addresses the issue that is laid out by my colleague @dtothefp here: optimizely#120

It will merge the existing user attributes with the current user's attributes to prevent losing the user attributes that are set when the optimizely client is initialized.

Sillhouette avatar Nov 01 '21 20:11 Sillhouette

Thanks for relating this to @dtothefp 's Issue and putting in the coding for it.

I've related and upgraded the internal ticket (FSSDK-8652).

When you have a chance, please review the CONTRIBUTING.md and sign the linked Contributors License Agreement (CLA).

mikechu-optimizely avatar Aug 29 '23 13:08 mikechu-optimizely

Thanks for relating this to @dtothefp 's Issue and putting in the coding for it.

I've related and upgraded the internal ticket (FSSDK-8652).

When you have a chance, please review the CONTRIBUTING.md and sign the linked Contributors License Agreement (CLA).

I've done that 👍

Sillhouette avatar Aug 29 '23 15:08 Sillhouette

I have already given my thought on this here in the issue comment. I think the way we handle overrides are intended this way.

But its an interesting idea, and we might revisit it in future if required.

Thanks!

junaed-optimizely avatar Nov 08 '24 11:11 junaed-optimizely