core icon indicating copy to clipboard operation
core copied to clipboard

[Feature Request] Make titles clickable in the Announcements dashboard widget

Open fongd opened this issue 1 year ago • 4 comments

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

  • [X] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
  • [X] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Is your feature request related to a problem? Please describe.

It's common for blog/post/forum/etc titles to be clickable to expand its content but in the current OPNsense implementation, you have to click the announcement's timestamp to go to the linked post.

Describe the solution you like

Please link the individual announcement's title to the corresponding forum post.

Describe alternatives you considered

N/A

Additional context

opnsense_announcement

A picture says a thousand words. :) The title in the red square should be a clickable link for each announcement.

fongd avatar Oct 09 '24 16:10 fongd

I did change it for exactly the opposite reason. GitHub and social media mostly has the links on the date.

fichtner avatar Oct 09 '24 17:10 fichtner

On the GitHub issues list, you click the issue title to "expand" the ticket. On sites like ArsTechnica, TheVerge, etc., you click the title to go to the article. Most RSS readers I've used let you click the title to expand that article. To me, clicking the date means that you want to see all articles posted on the same date, it's not as intuitive to me that you would click the date to see the post rather than the title (which also appears above the date in the Announcements widget so kinda makes sense that it should be clickable).

fongd avatar Oct 09 '24 19:10 fongd

On the GitHub issues list you don't read the issue contents. On the widget you do. :)

fichtner avatar Oct 09 '24 19:10 fichtner

Change in question: 929d779b7

To reiterate, the link style was distracting, the click is spurious since you already see the contents. Now the date was added and it was a good opportunity to remove the obvious link that leads to the same information.

I see your point, but I want to avoid to go back and forth because of style changes that will never make more than 50% happy.

fichtner avatar Oct 09 '24 19:10 fichtner

I don't know what the old link style looked like but there's no reason you couldn't keep the same link style as you have it now (orange bold, no underline) but make the title clickable. Add an underline on hover of the title if you are OK with that. It's clean and easy, and I will point out this is how it works in the OPNsense forums as well, not to mention countless other "list" styles elsewhere.

IMO, what's even more distracting is that the mouse pointer changes to a hand icon when hovering over any of the dashboard widgets, which makes it seem like you can click-to-drag to scroll the contents of said widget even though you can't. I just noticed this behaviour in Safari. But that is another issue so that's all I'll say on that.

Anyway, no need to monopolize your time on this. I understand certain decisions were made and I can respect that.

fongd avatar Oct 21 '24 04:10 fongd

This issue has been automatically timed-out (after 180 days of inactivity).

For more information about the policies for this repository, please read https://github.com/opnsense/core/blob/master/CONTRIBUTING.md for further details.

If someone wants to step up and work on this issue, just let us know, so we can reopen the issue and assign an owner to it.

OPNsense-bot avatar Apr 07 '25 15:04 OPNsense-bot