operatorfabric-core Update UI monitoring configuration when new monitoring configuration file is uploaded (#7243)

Fix #7243

In release notes :
- In chapter : Features
- Text : #7243 : Update UI monitoring configuration when new monitoring configuration file is uploaded

Summary by CodeRabbit

New Features
- Enhanced monitoring configuration management with event-driven notifications.
- Introduced a method for updating process monitoring configuration from a file.
- Added functionality to listen for monitoring configuration updates within the application.
- New observable for monitoring configuration change events to improve event handling.
Bug Fixes
- Improved error handling for unreadable monitoring configuration files.

Oct 02 '24 10:10 quinarygio

Walkthrough

The changes in this pull request involve modifications to several service classes within the application to enhance event-driven capabilities related to monitoring configurations. The MonitoringService has been updated to include an EventBus for sending event notifications upon configuration changes. The ProcessesService has introduced a new method for updating monitoring configurations and adjusted the visibility of existing methods. The ApplicationUpdateService now listens for monitoring configuration updates, while the OpfabEventStreamService has been enhanced to handle and emit events related to monitoring configuration changes.

Changes

File	Change Summary
`services/businessconfig/src/main/java/org/opfab/businessconfig/services/MonitoringService.java`	- Constructor updated to include `EventBus`. - `setMonitoring` method now sends an event on config change.
`services/businessconfig/src/main/java/org/opfab/businessconfig/services/ProcessesService.java`	- `loadProcessMonitoringCache` visibility changed to private. - New method `updateProcessMonitoringFile` added.
`ui/main/src/app/business/services/events/application-update.service.ts`	- New method `listenForMonitoringConfigUpdate` added to handle monitoring config updates.
`ui/main/src/app/business/services/events/opfabEventStream.service.ts`	- New static `Subject<void>` for monitoring config changes. - New method `getMonitoringConfigChangeRequests` added.

Assessment against linked issues

Objective	Addressed	Explanation
Update UI configuration when new monitoring configuration file is uploaded (#7243)	✅

Possibly related PRs

#7241: The changes in the main PR regarding the MonitoringService class and its integration with the EventBus are related to the modifications in the ProcessesService class, which also involves event handling for monitoring configuration changes. Both PRs enhance the event-driven capabilities of the monitoring services.

Suggested reviewers

freddidierRTE

Poem

In the burrow, changes hop,
Monitoring configs, never stop!
Events now dance, a joyful spree,
With updates sent, oh what glee!
From service to service, all in tune,
A rabbit's cheer beneath the moon! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between a79f8dfd578e5636f7cf45833ccdb255ecb6bcb4 and 9e529311080a2a9f7e5e8d8156492951d8c307bd.

📒 Files selected for processing (4)

services/businessconfig/src/main/java/org/opfab/businessconfig/services/MonitoringService.java (3 hunks)
services/businessconfig/src/main/java/org/opfab/businessconfig/services/ProcessesService.java (5 hunks)
ui/main/src/app/business/services/events/application-update.service.ts (2 hunks)
ui/main/src/app/business/services/events/opfabEventStream.service.ts (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (4)

services/businessconfig/src/main/java/org/opfab/businessconfig/services/MonitoringService.java
services/businessconfig/src/main/java/org/opfab/businessconfig/services/ProcessesService.java
ui/main/src/app/business/services/events/application-update.service.ts
ui/main/src/app/business/services/events/opfabEventStream.service.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json