operator-sdk icon indicating copy to clipboard operation
operator-sdk copied to clipboard

Make Badrobot work with SDK

Open jberkhahn opened this issue 3 years ago • 5 comments

Hey,

At Kubecon I attended a talk about operators as a threat vector to cluster security. I spoke with Kevin Ward (@wakeward), one of the maintainers on the project, about possibly integrating the tool they built, BadRobot. This issue is a place to discuss that.

Taking a look at the tool, it looks like the tool currently consumes a single yaml manifest that has been collated from the ones to provision the operator. I wonder if it would be possible to make it work on Bundles, at which point it could be packaged as a Validator, once we have External Validators working.

jberkhahn avatar May 24 '22 19:05 jberkhahn

More than happy to look at this. Regarding Bundles, I know you discussed with me rukpak Is this what you had in mind or support for CSV? I think it would also be good to understand how BadRobot will work in this instance (e.g. do you want all rulesets or a subset to start off with to encourage developers to review basic security configurations first?).

wakeward avatar May 25 '22 12:05 wakeward

When I say Bundles, I mean the off-cluster artifact that is produced by SDK when you package an operator for OLM, see example here. This is what is hosted on Operator Hub, and what our validators are run against. Due to rukpak it is likely the exact contents of a Bundle is going to change in the future, however.

jberkhahn avatar May 25 '22 18:05 jberkhahn

@ryantking is working on conversion logic from the current bundle format to the new rukpak format so he may have so additional insight as to the changes that a bundle may have in the future.

everettraven avatar May 25 '22 18:05 everettraven

For reference, here's the very WIP PR on that: https://github.com/operator-framework/rukpak/pull/396/files

ryantking avatar May 25 '22 19:05 ryantking

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Sep 12 '22 01:09 openshift-bot

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Oct 12 '22 08:10 openshift-bot

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Nov 12 '22 00:11 openshift-bot

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Nov 12 '22 00:11 openshift-ci[bot]