operator-registry icon indicating copy to clipboard operation
operator-registry copied to clipboard

:seedling: Bump Go v1.23.0

Open perdasilva opened this issue 1 year ago • 3 comments

Description of the change:

Motivation for the change:

Reviewer Checklist

  • [ ] Implementation matches the proposed design, or proposal is updated to match implementation
  • [ ] Sufficient unit test coverage
  • [ ] Sufficient end-to-end test coverage
  • [ ] Docs updated or added to /docs
  • [ ] Commit messages sensible and descriptive

perdasilva avatar Aug 29 '24 09:08 perdasilva

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 29 '24 09:08 openshift-ci[bot]

Codecov Report

Attention: Patch coverage is 0% with 112 lines in your changes missing coverage. Please review.

Project coverage is 46.82%. Comparing base (377b709) to head (5e4e1c2). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/api/registry_grpc.pb.go 0.00% 48 Missing :warning:
...ertools/containertoolsfakes/fake_command_runner.go 0.00% 16 Missing :warning:
pkg/sqlite/sqlitefakes/fake_rowscanner.go 0.00% 12 Missing :warning:
...s/containertoolsfakes/fake_dockerfile_generator.go 0.00% 4 Missing :warning:
...inertools/containertoolsfakes/fake_label_reader.go 0.00% 4 Missing :warning:
pkg/lib/indexer/indexerfakes/fake_index_adder.go 0.00% 4 Missing :warning:
pkg/lib/indexer/indexerfakes/fake_index_deleter.go 0.00% 4 Missing :warning:
...kg/lib/indexer/indexerfakes/fake_index_exporter.go 0.00% 4 Missing :warning:
.../lib/registry/registryfakes/fake_registry_adder.go 0.00% 4 Missing :warning:
...ib/registry/registryfakes/fake_registry_deleter.go 0.00% 4 Missing :warning:
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1431      +/-   ##
==========================================
+ Coverage   46.80%   46.82%   +0.01%     
==========================================
  Files         135      135              
  Lines       15760    15754       -6     
==========================================
  Hits         7377     7377              
+ Misses       7342     7336       -6     
  Partials     1041     1041              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 29 '24 09:08 codecov[bot]

/hold

perdasilva avatar Aug 29 '24 11:08 perdasilva

/hold cancel

@perdasilva can you rebase this one for queuing?

grokspawn avatar Dec 12 '24 20:12 grokspawn

/lgtm

camilamacedo86 avatar Jan 10 '25 14:01 camilamacedo86