operator-registry icon indicating copy to clipboard operation
operator-registry copied to clipboard

add bingo for managing tool deps

Open joelanford opened this issue 1 year ago • 2 comments

Description of the change:

  • Use bingo for tool management
  • Require a specific version of protoc (and include a helper that downloads it)

Motivation for the change:

  • Drive developer and CI consistency
  • Also note that protoc is not a go binary, so it requires a separate helper script to download it and check its version.

Reviewer Checklist

  • [ ] Implementation matches the proposed design, or proposal is updated to match implementation
  • [ ] Sufficient unit test coverage
  • [ ] Sufficient end-to-end test coverage
  • [ ] Docs updated or added to /docs
  • [ ] Commit messages sensible and descriptive

joelanford avatar May 29 '24 16:05 joelanford

Codecov Report

Attention: Patch coverage is 0% with 61 lines in your changes missing coverage. Please review.

Project coverage is 48.13%. Comparing base (da4828d) to head (2309760). Report is 41 commits behind head on master.

Files Patch % Lines
alpha/template/basic/basic.go 0.00% 41 Missing :warning:
alpha/template/converter/converter.go 0.00% 14 Missing :warning:
alpha/declcfg/load.go 0.00% 6 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1329      +/-   ##
==========================================
- Coverage   50.02%   48.13%   -1.89%     
==========================================
  Files         135      134       -1     
  Lines       13006    12752     -254     
==========================================
- Hits         6506     6138     -368     
- Misses       5416     5577     +161     
+ Partials     1084     1037      -47     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 29 '24 16:05 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, joelanford, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [grokspawn,joelanford,perdasilva]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jul 30 '24 12:07 openshift-ci[bot]