operator-lifecycle-manager icon indicating copy to clipboard operation
operator-lifecycle-manager copied to clipboard

chore: pkg import only once

Open testwill opened this issue 2 years ago • 6 comments

Description of the change:

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • [ ] Implementation matches the proposed design, or proposal is updated to match implementation
  • [ ] Sufficient unit test coverage
  • [ ] Sufficient end-to-end test coverage
  • [ ] Bug fixes are accompanied by regression test(s)
  • [ ] e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • [ ] tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • [ ] Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • [ ] Docs updated or added to /doc
  • [ ] Commit messages sensible and descriptive
  • [ ] Tests marked as [FLAKE] are truly flaky and have an issue
  • [ ] Code is properly formatted

testwill avatar Nov 23 '23 07:11 testwill

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: testwill Once this PR has been reviewed and has the lgtm label, please assign grokspawn for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Nov 23 '23 07:11 openshift-ci[bot]

Hi @testwill. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Nov 23 '23 07:11 openshift-ci[bot]

Thanks for the commit! Just one comment

stevekuznetsov avatar Nov 30 '23 15:11 stevekuznetsov

Thanks! This is ready to go

stevekuznetsov avatar Dec 01 '23 14:12 stevekuznetsov

/ok-to-test

ankitathomas avatar Jan 03 '24 16:01 ankitathomas

Thank you @testwill ^^ could I please ask you to rebase and resolve conflicts? Then we can get this merged =D

perdasilva avatar Apr 09 '24 09:04 perdasilva

merging since Steve gave the go ahead (but forgot to approve)

perdasilva avatar Apr 11 '24 12:04 perdasilva