operator-lifecycle-manager icon indicating copy to clipboard operation
operator-lifecycle-manager copied to clipboard

Multiple operatorGroup error in subscription status

Open awgreene opened this issue 3 years ago • 1 comments

Problem: When reconciling subscriptions in a namespace, OLM will error out if multiple operatorGroups exist in the namespace when deciding if the fail-forward feature is enabled. The failure is only loged and not surfaced in the status of the subscription.

Solution: By assuming that fail forward is disabled when more than one operatorGroups are found in a namespace, the syncResolvingNamespace function will attempt to find upgrades using the resolver which will fail due to multiple operatorGroups in the namespace anyways and portray this information in the subscription status.

awgreene avatar May 10 '22 18:05 awgreene

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 10 '22 18:05 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas, awgreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Mar 18 '23 02:03 openshift-ci[bot]

@awgreene could you please rebase? I can't do it from this side =(

perdasilva avatar Apr 12 '23 12:04 perdasilva

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Apr 12 '23 17:04 openshift-ci[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot avatar May 27 '23 23:05 openshift-merge-robot