operator-controller icon indicating copy to clipboard operation
operator-controller copied to clipboard

Published 20 hours ago • verified publisher icon operator-framework

🌱 Proposed way to unskip some tests

Open bentito opened this issue 1 year ago • 1 comments

Description

TestClusterExtensionChannelVersionExists mostly restored here.

This is a proposed way to change the other skipped tests as well.

Items skipped by the last conditional are:

  • Bundle Deployment related (can likely just be removed);
  • Invariant or other conditions on code paths we're avoiding due to a desire to lessen the mocking.

Reviewer Checklist

  • [ ] API Go Documentation
  • [ ] Tests: Unit Tests (and E2E Tests, if appropriate)
  • [x] Comprehensive Commit Messages
  • [ ] Links to related GitHub Issue(s)

bentito avatar May 20 '24 20:05 bentito

@bentito: https://github.com/operator-framework/operator-controller/commit/d649164d840340ae475ba434caf4af2fb33ac801 - I tried making changes to your branch, but GH doesn't let me create a PR against your repo 😅 With this change, we don't need to mock the loader itself. We use the mock unpacker to return UnpackPending and test relevant conditions which is equivalent on what the test did previously.

varshaprasad96 avatar May 21 '24 18:05 varshaprasad96