operator-controller icon indicating copy to clipboard operation
operator-controller copied to clipboard

✨ Add optional field to ClusterExtension API to skip CRD upgrade safety checks

Open rashmigottipati opened this issue 1 year ago • 4 comments

Description

Adds an optional ClusterExtension.spec.skipCRDUpgradeSafetyChecks field that when set to true will be used to disable the CRD upgrade safety checks when attempting to install a cluster extension.

No logic included in this PR as the CRD Upgrade Safety preflight check as there isn't anything yet to enable/disable. So logic to enable/disable will be added in a future PR once everything is in place.

fixes https://github.com/operator-framework/operator-controller/issues/745

Reviewer Checklist

  • [ ] API Go Documentation
  • [ ] Tests: Unit Tests (and E2E Tests, if appropriate)
  • [ ] Comprehensive Commit Messages
  • [ ] Links to related GitHub Issue(s)

rashmigottipati avatar May 10 '24 16:05 rashmigottipati

Deploy Preview for olmv1 ready!

Name Link
Latest commit fffc98a0a57f9d860aab3a2347a36bd8edfe28bd
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6643b1c826b7530008dd9348
Deploy Preview https://deploy-preview-845--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 10 '24 16:05 netlify[bot]

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 70.05%. Comparing base (e9acbd3) to head (e35ad16).

Files Patch % Lines
api/v1alpha1/zz_generated.deepcopy.go 0.00% 18 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #845      +/-   ##
==========================================
- Coverage   71.02%   70.05%   -0.97%     
==========================================
  Files          17       17              
  Lines        1301     1319      +18     
==========================================
  Hits          924      924              
- Misses        304      322      +18     
  Partials       73       73              
Flag Coverage Δ
e2e 43.36% <0.00%> (-0.60%) :arrow_down:
unit 62.66% <0.00%> (-0.93%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 10 '24 17:05 codecov[bot]

Please hold this from merging till #846 gets in. Thanks!

varshaprasad96 avatar May 15 '24 15:05 varshaprasad96

/hold

rashmigottipati avatar May 15 '24 18:05 rashmigottipati

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot avatar Jun 14 '24 20:06 openshift-merge-robot

@rashmigottipati should we close this? Am I correct in assuming that #979 makes this obsolete?

joelanford avatar Jul 03 '24 20:07 joelanford

@joelanford yes, https://github.com/operator-framework/operator-controller/pull/979 makes this obsolete. Will close this

rashmigottipati avatar Jul 03 '24 20:07 rashmigottipati