operator-controller icon indicating copy to clipboard operation
operator-controller copied to clipboard

✨ make extension and clusterextension api consistent

Open ankitathomas opened this issue 1 year ago • 5 comments

This PR makes the clusterextension api more consistent with the extension api by:

  • copying over missing fields to the clusterextension api
  • adding the Progressing condition to indicate a progressing installation
  • updating the Installed condition to match the extension controller's behavior.

ankitathomas avatar May 09 '24 04:05 ankitathomas

Deploy Preview for olmv1 ready!

Name Link
Latest commit 27ad2301a83671863ffbdf6dcbb42a699a3e39d8
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/665dd6c0dd249c000826628c
Deploy Preview https://deploy-preview-842--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 09 '24 04:05 netlify[bot]

Codecov Report

Attention: Patch coverage is 70.47619% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 71.70%. Comparing base (6d73b73) to head (a934c27). Report is 10 commits behind head on main.

Files Patch % Lines
api/v1alpha1/zz_generated.deepcopy.go 34.78% 15 Missing :warning:
...nternal/controllers/clusterextension_controller.go 70.00% 9 Missing and 3 partials :warning:
internal/controllers/extension_controller.go 76.47% 4 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
+ Coverage   71.02%   71.70%   +0.68%     
==========================================
  Files          17       18       +1     
  Lines        1301     1329      +28     
==========================================
+ Hits          924      953      +29     
+ Misses        304      300       -4     
- Partials       73       76       +3     
Flag Coverage Δ
e2e 44.77% <55.23%> (+2.03%) :arrow_up:
unit 63.76% <61.90%> (+0.17%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 09 '24 04:05 codecov[bot]

Please hold this from merging till https://github.com/operator-framework/operator-controller/pull/846 gets in. Thanks!

varshaprasad96 avatar May 15 '24 15:05 varshaprasad96

/hold

ankitathomas avatar May 15 '24 17:05 ankitathomas