operator-controller icon indicating copy to clipboard operation
operator-controller copied to clipboard

Flake in operator-developer-e2e: potentially due to GitHub rate-limiting

Open joelanford opened this issue 2 years ago • 4 comments

https://github.com/operator-framework/operator-controller/actions/runs/5871742974/job/15921834994?pr=336#step:4:484

Looks like the culprit is that we're trying to curl | sh for a kustomize binary install and we're getting rate-limited by GitHub

{ curl -Ss "[https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh](https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh/)" | bash -s -- 3.8.7 /home/runner/work/operator-controller/operator-controller/test/operator-framework-e2e/registry-operator/bin; }\nGithub rate-limiter failed the request. Either authenticate or wait a couple of minutes.

joelanford avatar Aug 15 '23 21:08 joelanford

It appears that the curl command comes from operator-sdk, which comes from kubebuilder. I found a change to operator-sdk that updates kubebuilder, which also appears to change the install of kustomize from using go get to curl. See: https://github.com/operator-framework/operator-sdk/blob/master/website/content/en/docs/upgrading-sdk-version/v1.21.0.md Which leads to: https://github.com/operator-framework/operator-sdk/pull/4863/files It appears we regressed from v3.0.0 to v3.0.0-alpha.0.0.20210503171920-2b857cb37698 But the latest operator-sdk uses kubebuilder/v3-v3.9.1, and that kubebuilder still curls kustomize

tmshort avatar Aug 16 '23 16:08 tmshort

If we're inheriting that from kubebuilder -> operator-sdk, I guess it makes sense for us to NOT try to work around that.

After all, that's sort of the point of this e2e: does the soup to nuts work without requiring users to make tweaks.

joelanford avatar Aug 16 '23 18:08 joelanford

We could try to add a manual retry, but yeah, we really can't change it.

tmshort avatar Aug 16 '23 18:08 tmshort

We could try to add a manual retry, but yeah, we really can't change it.

This line would need to be retried if we wanted a fix before operator-sdk updates.

tmshort avatar Aug 16 '23 19:08 tmshort

Job log is no longer available. Also we now install kustomize via bingo. It looks like obsolete, so I'm closing this.

m1kola avatar Oct 04 '24 10:10 m1kola