operator-controller icon indicating copy to clipboard operation
operator-controller copied to clipboard

🌱 Add prometheus to e2e workflow

Open dtfranz opened this issue 7 months ago β€’ 4 comments

Description

Closes #1902

Adds an additional e2e Makefile target which runs the e2e with prometheus deployed. This will allow us to check for alerts and potential performance degradation after e2e runs.

Starting out with just the minimal install as opposed to the entire kube-prometheus stack, which has far more than we need right now.

Reviewer Checklist

  • [ ] API Go Documentation
  • [ ] Tests: Unit Tests (and E2E Tests, if appropriate)
  • [ ] Comprehensive Commit Messages
  • [ ] Links to related GitHub Issue(s)

dtfranz avatar Apr 17 '25 16:04 dtfranz

Deploy Preview for olmv1 ready!

Name Link
Latest commit 90c6b467945d254adc4bfd7a07aa9ed9178bbb98
Latest deploy log https://app.netlify.com/projects/olmv1/deploys/684ad8958c8328000810ef5e
Deploy Preview https://deploy-preview-1928--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Apr 17 '25 16:04 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.26%. Comparing base (44de6f2) to head (90c6b46). Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1928      +/-   ##
==========================================
+ Coverage   69.21%   69.26%   +0.04%     
==========================================
  Files          79       79              
  Lines        7037     7051      +14     
==========================================
+ Hits         4871     4884      +13     
  Misses       1885     1885              
- Partials      281      282       +1     
Flag Coverage Ξ”
e2e 42.94% <ΓΈ> (-0.12%) :arrow_down:
unit 60.17% <ΓΈ> (+0.10%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 17 '25 16:04 codecov[bot]

So, this adds a new e2e that isn't run downstream? There's no workflow to run it in upstream CI?

tmshort avatar Apr 18 '25 13:04 tmshort

So, this adds a new e2e that isn't run downstream? There's no workflow to run it in upstream CI?

Yes - it currently only adds prometheus to the environment when you run the new e2e target, so I've kept the workflow the same for now. If you'd prefer I'm happy to make that change here - it doesn't add much overhead to the e2e at all.

dtfranz avatar Apr 21 '25 20:04 dtfranz

I reran it and it passed, seems a test flaked 🫀

dtfranz avatar Jun 12 '25 08:06 dtfranz

/lgtm

camilamacedo86 avatar Jun 23 '25 18:06 camilamacedo86

/approve

tmshort avatar Jun 24 '25 13:06 tmshort

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jun 24 '25 13:06 openshift-ci[bot]