operator-controller icon indicating copy to clipboard operation
operator-controller copied to clipboard

:sparkles: reduce use of carvel validators

Open everettraven opened this issue 1 year ago • 2 comments

Description

  • Reduces the use of the field change validators in carvel/kapp in favor of our own implementations. This makes the CRD Upgrade Safety pre-flight check more maintainable by allowing us to make bugfixes and changes in our implementation without having to contribute to carvel/kapp and wait for a new release.

  • fixes #1248

  • fixes #1246

Reviewer Checklist

  • [ ] API Go Documentation
  • [ ] Tests: Unit Tests (and E2E Tests, if appropriate)
  • [ ] Comprehensive Commit Messages
  • [ ] Links to related GitHub Issue(s)

everettraven avatar Sep 13 '24 20:09 everettraven

Deploy Preview for olmv1 ready!

Name Link
Latest commit 787b14815e628f68fae683e2125f6b4289dd380e
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66e9d478bd252600093fc888
Deploy Preview https://deploy-preview-1269--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 13 '24 20:09 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.87%. Comparing base (188858c) to head (787b148). Report is 102 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1269      +/-   ##
==========================================
+ Coverage   76.51%   77.87%   +1.36%     
==========================================
  Files          40       40              
  Lines        2363     2509     +146     
==========================================
+ Hits         1808     1954     +146     
  Misses        389      389              
  Partials      166      166              
Flag Coverage Δ
e2e 54.52% <7.64%> (-3.33%) :arrow_down:
unit 55.79% <100.00%> (+2.73%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 13 '24 21:09 codecov[bot]

Where are we on this one?

tmshort avatar Nov 01 '24 14:11 tmshort