operator-controller icon indicating copy to clipboard operation
operator-controller copied to clipboard

✨ [WIP] Add support for kubectl printer columns

Open kevinrizza opened this issue 1 year ago • 5 comments

Adds installed version, resolved version and age printer columns

Resolves https://github.com/operator-framework/operator-controller/issues/1018

Description

Reviewer Checklist

  • [ ] API Go Documentation
  • [ ] Tests: Unit Tests (and E2E Tests, if appropriate)
  • [ ] Comprehensive Commit Messages
  • [ ] Links to related GitHub Issue(s)

kevinrizza avatar Jul 08 '24 19:07 kevinrizza

These seem like reasonable printer columns to me, but we should have some agreement that these make the most sense before committing to them. Leaving this as a WIP pr for now.

kevinrizza avatar Jul 08 '24 19:07 kevinrizza

Deploy Preview for olmv1 ready!

Name Link
Latest commit 2fd9441e5541913a66c9cd4b2bfebac0ec4ef4bd
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/668c3ec963ac8f0008d7595a
Deploy Preview https://deploy-preview-1019--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 08 '24 19:07 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.05%. Comparing base (235e3d4) to head (2fd9441). Report is 242 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1019   +/-   ##
=======================================
  Coverage   78.05%   78.05%           
=======================================
  Files          18       18           
  Lines        1253     1253           
=======================================
  Hits          978      978           
  Misses        193      193           
  Partials       82       82           
Flag Coverage Δ
e2e 56.65% <ø> (ø)
unit 53.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 08 '24 19:07 codecov[bot]

@joelanford I looked around and didn't find anything. Imo we should keep this pr held until we make some improvements to the availability of this metadata. I'm also interested in any other thoughts on other columns we might want to have.

kevinrizza avatar Jul 12 '24 13:07 kevinrizza

Where are we on this? Keeping it? Does it need rework?

tmshort avatar Sep 10 '24 18:09 tmshort

/hold

This is now out of date, the fields no longer exist.

tmshort avatar Oct 31 '24 20:10 tmshort

Closing if favour of #1421

m1kola avatar Nov 04 '24 10:11 m1kola