Quarkus sample documentation and artifacts are not aligned with the Spring Boot sample project

[jareso-sidero]

Hi guys, I am noticing that the README.md in quarkus project just explains how to compile and execute the quarkus sample. I don't know Spring boot, but I found documentation and a yaml file not included in the Quarkus sample, that explains how to make the Spring boot sample work, the use case and the steps to test the sample.

Could this all be brought to Quarkus sample project?

[csviri]

Hi @jareso-sidero , will update the documentation, but might help to check the E2E tests:

https://github.com/operator-framework/josdk-webhooks/blob/0dd5c04085e1145c90bcf73a0fb943bf38bcb0e5/samples/quarkus/src/test/java/io/javaoperatorsdk/webhook/sample/QuarkusWebhooksE2E.java

That deploys the webhooks and tests them, you can also reproduce the same manually.

[jareso-sidero]

Thanks Attila,

I will do that.

Jesus

On Mon, 2023-10-23 at 03:06 -0700, Attila Mészáros wrote:

WARNING: This email has come from an external source. Do not reply, click links or open attachments unless you know and trust the sender and know the content is secure.

Hi @jareso-siderohttps://github.com/jareso-sidero , will update the documentation, but might help to check the E2E tests: /home/csviri/Workspace/josdk-webhooks/samples/quarkus/src/test/java/io/javaoperatorsdk/webhook/sample/QuarkusWebhooksE2E.java

That deploys the webhooks and tests them, you can also reproduce the same manually.

— Reply to this email directly, view it on GitHubhttps://github.com/operator-framework/josdk-webhooks/issues/169#issuecomment-1774851829, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZUQXPFLVKBE4NXFIEZYZHLYAY6SRAVCNFSM6AAAAAA6G36V4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZUHA2TCOBSHE. You are receiving this because you were mentioned.Message ID: @.***>

SIDERO CONFIDENTIALITY NOTICE - The information contained in this email message is intended only for the confidential use of the named recipient. If the reader of this message is not the intended recipient or the person responsible for delivering it to the recipient, you are hereby notified that you have received this communication in error and that any review, dissemination or copying of this communication is strictly prohibited. If you have received this in error, please notify the sender immediately.