java-operator-sdk icon indicating copy to clipboard operation
java-operator-sdk copied to clipboard

Workflow Cycle Detection - Explicit Cycle Logging

Open csviri opened this issue 3 years ago • 3 comments

Workflows are essentially acyclic, detecting cycles is already implemented in PR: https://github.com/java-operator-sdk/java-operator-sdk/pull/1257

However this approach does not log the detected cycle - just logs that "there is a cycle" - thus nodes involved in the cycle. It would improve the developer experience if the cycle is clearly logged.

csviri avatar Jun 08 '22 07:06 csviri

IMO this is a low priority issue since its not hard to find the cycles just by looking on the declaration of the workflow. It is not that we are solving a very complex bean structure across the code, it is expected to be relatively simple DAG declared in very transparent way in one place.

csviri avatar Jun 08 '22 07:06 csviri

Agreed, while my inner geek would like super neat graph algorithms and optimisations, we probably don't need them at this point.

metacosm avatar Jun 08 '22 21:06 metacosm

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Aug 08 '22 03:08 github-actions[bot]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Oct 08 '22 03:10 github-actions[bot]

This issue was closed because it has been stalled for 14 days with no activity.

github-actions[bot] avatar Oct 22 '22 03:10 github-actions[bot]