zipkin-ruby icon indicating copy to clipboard operation
zipkin-ruby copied to clipboard

Add setting to disable shared spans (joins) in tracer.

Open tylerbenson opened this issue 7 years ago • 2 comments
trafficstars

Other tracer implementations include a setting to force client and server spans to have different spanId's. In Go the setting is WithSharedSpans(false) and in Java it's supportsJoin(false).

There should be something similar in ruby.

This is important because zipkin traces may be reported to non-zipkin backends that might not support the concept of joining spans.

tylerbenson avatar Jul 11 '18 22:07 tylerbenson

agree. I encountered a problem when use jaeger client send request to zipkin client, and the backend server is jaeger server. It will report the duplicate span ID.

dpdpbj avatar Nov 22 '19 05:11 dpdpbj

I think the main reason here is feature parity with other languages. Whether Jaeger supports it or not might be discussed in their forums.

@dp9463 are you up for a PR?

jcchavezs avatar Nov 22 '19 07:11 jcchavezs