zipkin-go icon indicating copy to clipboard operation
zipkin-go copied to clipboard

When serializing SpanModel, if there is any external modification of TAGS, it will lead to panic, add RLock before calling Send to prevent this error.

Open php-lsys opened this issue 2 years ago • 2 comments

When serializing SpanModel, if there is any external modification of TAGS, it will lead to panic, add RLock before calling Send to prevent this error. issues:https://github.com/openzipkin/zipkin-go/issues/217

php-lsys avatar Nov 27 '23 09:11 php-lsys

LGTM

jcchavezs avatar Nov 27 '23 10:11 jcchavezs

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (87e3b85) 66.83% compared to head (c8522fb) 69.29%. Report is 2 commits behind head on master.

Files Patch % Lines
span_implementation.go 66.66% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
+ Coverage   66.83%   69.29%   +2.45%     
==========================================
  Files          36       36              
  Lines        1770     2501     +731     
==========================================
+ Hits         1183     1733     +550     
- Misses        542      723     +181     
  Partials       45       45              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 27 '23 10:11 codecov[bot]