zipkin-go icon indicating copy to clipboard operation
zipkin-go copied to clipboard

Published 20 hours ago • verified publisher icon openzipkin

Add GCP Cloud PubSub reporter

Open KeisukeYamashita opened this issue 5 years ago • 5 comments
trafficstars

What

  • Originally this PR is from https://github.com/openzipkin/zipkin-go/pull/142
    • It seems stale and taking over the that PR
  • Add GCP Cloud reporter

Why

  • https://github.com/openzipkin/zipkin-gcp/issues/132
  • https://github.com/openzipkin/zipkin-go/pull/142#issuecomment-558739097

KeisukeYamashita avatar Nov 26 '19 22:11 KeisukeYamashita

Coverage Status

Coverage increased (+2.4%) to 67.92% when pulling 89d56c947a44a56d79a0d0384ed4dc76b25ddade on KeisukeYamashita:add-gcp-pubsub-exporter into d761b1950c490079bfbfab289c129f46ee5d6f33 on openzipkin:master.

coveralls avatar Nov 26 '19 22:11 coveralls

Coverage Status

Coverage decreased (-4.9%) to 60.568% when pulling 386fed93880345f68d93b06b94d90f7e08091a41 on KeisukeYamashita:add-gcp-pubsub-exporter into d761b1950c490079bfbfab289c129f46ee5d6f33 on openzipkin:master.

coveralls avatar Nov 26 '19 22:11 coveralls

I will use stubReporter. Working on in now.

KeisukeYamashita avatar Nov 28 '19 02:11 KeisukeYamashita

I introduce stubReporter and stubClient. In the previous https://github.com/openzipkin/zipkin-go/pull/142, the pubsub topic will be nil and the test will always pass.

KeisukeYamashita avatar Dec 07 '19 07:12 KeisukeYamashita

Any feedback @basvanbeek ?

jcchavezs avatar May 07 '20 13:05 jcchavezs