OpenWPM icon indicating copy to clipboard operation
OpenWPM copied to clipboard

[WIP] Move dns_instrument from onCompleted to onHeadersReceived

Open englehardt opened this issue 2 years ago • 3 comments
trafficstars

Fixes #1020 WIP. I haven't tested this much.

englehardt avatar Jan 12 '23 04:01 englehardt

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7b8cf99) 45.74% compared to head (8a855a4) 45.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1021   +/-   ##
=======================================
  Coverage   45.74%   45.74%           
=======================================
  Files          35       35           
  Lines        3478     3478           
=======================================
  Hits         1591     1591           
  Misses       1887     1887           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 12 '23 04:01 codecov-commenter

Good Catch! Does this also resolve the issue where DNS requests for domains that don't resolved aren't captured?

vringar avatar Jan 12 '23 14:01 vringar

I'm not sure. I'll need to write a test page for both of these conditions.

englehardt avatar Jan 16 '23 02:01 englehardt