bifold-wallet icon indicating copy to clipboard operation
bifold-wallet copied to clipboard

feat: wallet history module core components

Open MosCD3 opened this issue 1 year ago • 3 comments
trafficstars

Summary of Changes

The history module will allow wallet users to track VC and general wallet events. This PR is the base components needed to create the module. The PR will include the following

  • Initializing history module to record events on-demand
  • Recording accepted credentials only for now
  • Viewing history
  • Setting history record options screen This is considered the very basic components. Planned to be further developed after this is merged
  • Adding queer service to record events before wallet initializes such as first creating PIN
  • Filtering and trimming old history items
  • History details
  • Expanding history record events to be hooked to all VC related events

This is an overhaul for the previous PR that was created earlier before moving to credo Major updates

  • History is used as manager class initialized by app container instead of using provider
  • Behind a feature flag toggled in Developer menu
  • Hooked up to accepting new Crew. offer only as an MVP

Related Issues

Please reference here any issue #'s that are relevant to this PR, or simply enter "N/A" if this PR does not relate to any existing issues.

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • [x] All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • [x] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • [x] Updated documentation as needed for changed code and new or modified features;
  • [x] Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

MosCD3 avatar Jun 03 '24 05:06 MosCD3

able to fix the opposite operator issue found by sonarcloud? The rest are mostly TODO warnings or not from your code, so not to worry about those, but I agree with the opposite operator suggestion

bryce-mcmath avatar Jun 20 '24 22:06 bryce-mcmath

Codecov Report

Attention: Patch coverage is 6.91824% with 296 lines in your changes missing coverage. Please review.

Project coverage is 59.61%. Comparing base (4ef5d9d) to head (5359a64). Report is 17 commits behind head on main.

Files Patch % Lines
...ore/App/modules/history/context/historyManager.tsx 0.00% 94 Missing :warning:
.../modules/history/ui/components/HistoryListItem.tsx 2.94% 66 Missing :warning:
...cy/core/App/modules/history/ui/HistorySettings.tsx 2.17% 45 Missing :warning:
...legacy/core/App/modules/history/ui/HistoryPage.tsx 2.77% 35 Missing :warning:
...odules/history/ui/components/SingleSelectBlock.tsx 13.33% 13 Missing :warning:
...core/App/modules/history/services/quee.service.tsx 9.09% 10 Missing :warning:
...ckages/legacy/core/App/screens/CredentialOffer.tsx 44.44% 10 Missing :warning:
...ackages/legacy/core/App/contexts/reducers/store.ts 0.00% 6 Missing :warning:
...re/App/modules/history/navigation/HistoryStack.tsx 16.66% 5 Missing :warning:
.../App/modules/history/ui/components/HistoryMenu.tsx 20.00% 4 Missing :warning:
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1151      +/-   ##
==========================================
- Coverage   62.23%   59.61%   -2.63%     
==========================================
  Files         181      191      +10     
  Lines        5940     6349     +409     
  Branches     1701     1788      +87     
==========================================
+ Hits         3697     3785      +88     
- Misses       2222     2543     +321     
  Partials       21       21              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 24 '24 01:06 codecov-commenter

Looks good can we get it up to date with main?

bryce-mcmath avatar Jul 22 '24 17:07 bryce-mcmath

@MosCD3 , just waiting for a rebase so we can merge this PR. Maybe give us a heads so we can stop merging PR for a little bit to give you time to rebase

cvarjao avatar Jul 23 '24 16:07 cvarjao

rebase done

MosCD3 avatar Jul 23 '24 16:07 MosCD3