openvino icon indicating copy to clipboard operation
openvino copied to clipboard

Published 20 hours ago • verified publisher icon openvinotoolkit

[Transformations] Add downgrade transformation for `AvgPool-14` and `MaxPool-14`

Open p-wysocki opened this issue 1 year ago • 4 comments

Details

  • Add downgrade transformation AvgPool-14 -> AvgPool-1
  • Add downgrade transformation MaxPool-14 -> MaxPool-8
  • This PR unblocks PT FE extension

Related PRs

  • https://github.com/openvinotoolkit/openvino/pull/22796
  • https://github.com/openvinotoolkit/openvino/pull/22930
  • https://github.com/openvinotoolkit/openvino/pull/22966
  • https://github.com/openvinotoolkit/openvino/pull/23027
  • https://github.com/openvinotoolkit/openvino/pull/23582

Tickets:

  • 133918

p-wysocki avatar Mar 11 '24 15:03 p-wysocki

Core implementation has been merged, this PR now blocks PT FE extension. cc @mitruska @praasz

p-wysocki avatar Mar 14 '24 12:03 p-wysocki

Should an edge case of dynamic shapes + ov::op::RoundingType::CEIL_TORCH downgrade be supported? It requires quite a complex subgraph, it's hard to tell how frequent that pattern will be. cc @praasz @mitruska

p-wysocki avatar Apr 05 '24 14:04 p-wysocki

Should an edge case of dynamic shapes + ov::op::RoundingType::CEIL_TORCH downgrade be supported? It requires quite a complex subgraph, it's hard to tell how frequent that pattern will be. cc @praasz @mitruska

There is no such need if the dynamic shape case was not supported by the subgraph produced by the frontend (considered as work-around solution). The goal of this decomposition is to ensure backward compatibility, during plugins migration to the newer version of the Max/AvgPool operation.

mitruska avatar Apr 05 '24 15:04 mitruska

@praasz @mitruska could you please rereview?

p-wysocki avatar Apr 23 '24 07:04 p-wysocki